Same chain multichain deposits and withdrawals FEDEV-3201 #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added AVALANCHE_FUJI to settlement and source chain IDs. - Enhanced source chain validation in various components to include the current chain context. - Updated multichain token mappings and added new functions for gas estimation on same-chain transactions. - Refactored related components to ensure proper handling of source and settlement chains. - Cleaned up unused imports and improved code readability across multiple files.
Deploying gmx-interface-home with
|
| Latest commit: |
127dbf5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf5f9589.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://same-chain-multichain.gmx-interface-home.pages.dev |
Deploying gmx-interface with
|
| Latest commit: |
127dbf5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29ae2cf2.gmx-interface.pages.dev |
| Branch Preview URL: | https://same-chain-multichain.gmx-interface.pages.dev |
…nd improve source chain handling - Changed the estimated time text from Instantly to Instant in DepositView and WithdrawalView components. - Enhanced source chain logic in TransferDetailsView to ensure accurate chain identification for transactions. - Updated localization files to reflect the change in text for multiple languages.
…bling functionality - Added support for disabling dropdown items in DropdownSelector based on custom logic, including tooltip messages for disabled items. - Introduced a new sorting function for token data in WithdrawalView to improve the display of transferable tokens. - Updated localization files to include messages for unsupported withdrawal scenarios across multiple languages.
…lity - Introduced multichain funding tracking by adding to manage pending transactions. - Updated DepositView and WithdrawalView to handle multichain deposit and withdrawal events, including logging and toast notifications for transaction success and failure. - Refactored token balance handling in SelectAssetToDepositView to use instead of . - Improved transaction receipt handling to capture bridge events and update pending funding states accordingly.
midas-myth
force-pushed
the
same-chain-multichain
branch
from
0f04d77 to
404f3f2
Compare
midas-myth
force-pushed
the
same-chain-multichain
branch
from
404f3f2 to
9a51810
Compare
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
qwinndev
reviewed
Jan 15, 2026
|
|
||
| const filteredBalances: DisplayTokenChainData[] = useMemo(() => { | ||
| return tokenChainDataArray | ||
| const multichainTokens = tokenChainDataArray |
Contributor
There was a problem hiding this comment.
can we extract this code to some pure function? maybe even two and then compose them
getMultichainTokens
getSettlementChainTokens
| return isFirstWithdrawal; | ||
| }; | ||
|
|
||
| function tokenDataSorter(a: TokenData, b: TokenData): 1 | -1 | 0 { |
Contributor
There was a problem hiding this comment.
let's add byBalance to name and move it to some tokens utils file
| ); | ||
| return mappedTokenId !== undefined; | ||
| }); | ||
| return networks |
Contributor
There was a problem hiding this comment.
let's create getActiveNetworks or something like that
|
|
||
| return ( | ||
| MULTI_CHAIN_WITHDRAWAL_TRADE_TOKENS[chainId as SettlementChainId] | ||
| const multichainTokens = |
Contributor
There was a problem hiding this comment.
can it be moved to function?
| } | ||
| ); | ||
|
|
||
| const sameChainNetworkFee = useMemo((): |
| await sendWalletTransaction({ | ||
| chainId, | ||
| to: getContract(chainId, "MultichainTransferRouter"), | ||
| await sendSameChainWithdrawalTxn({ |
Contributor
There was a problem hiding this comment.
looks really big can we extract that to hook?
Contributor
Author
There was a problem hiding this comment.
extracted to useWithdrawViewTransactions and inside handleSameChainWithdraw and handleMultichainWithdraw
…iews - Introduced calculateNetworkFeeDetails function to encapsulate network fee calculations based on gas limit and price. - Refactored DepositView to utilize the new fee calculation function, improving readability and maintainability. - Updated WithdrawalView to replace inline fee calculations with the new utility function. - Enhanced token sorting and filtering logic in SelectAssetToDepositView for better performance and clarity. - Adjusted indexer URLs and multichain configurations for consistency across environments.
Contributor
Author
|
@cursor review |
qwinndev
approved these changes
Jan 15, 2026
Contributor
Author
|
@cursor review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.